misc: Allow setting init_containers with null condition #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/terratest |
gberenice
reviewed
Oct 14, 2024
|
💥 This pull request now has conflicts. Could you fix it @adamantike? 🙏 |
This change allows configuring `init_containers` that are not added to the `depends_on` list for the main container, by setting `null` as the container `condition`. This is useful for containers that actually depend on the main container, and not the other way around. For example, a `nginx` sidecar that needs to wait for the main container to be healthy before starting. By allowing `null` as the container condition, this is a non-breaking change.
adamantike
force-pushed
the
misc/allow-init-containers-without-condition
branch
from
36f8b35
to
9bf8f85
Compare
|
/terratest |
gberenice
approved these changes
Oct 16, 2024
|
These changes were released in v2.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This change allows configuring
init_containersthat are not added to thedepends_onlist for the main container, by settingnullas the containercondition.why
This is useful for containers that actually depend on the main container, and not the other way around. For example, a
nginxsidecar that needs to wait for the main container to be healthy before starting.By allowing
nullas the container condition, this is a non-breaking change.