improve release/zip targets, cleanup #100
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main: improve zipfile output steps
other/cleanup:
I'm not super-familiar with how projects are using BIN_TARGET or any of the other stuff, so if anything here breaks other existing projects, let me know, I can modify. I would think it's all pretty compatible though. I'm also a little weak on my Makefile-fu, so if I'm doing anything silly, let me know.
Unrelated stuff
Figured I'd just throw this over here, in case useful for anyone.
I made the above Makefile changes as part of a docker-based CI buildsystem for esp8266 projects. It seems to be working well so far. If interested, I could try to get this setup better / documented for general use.
It's available here in this branch:
https://github.com/Unit-e/esp-open-sdk-docker/blob/cnlohr-use-esp82xx-prebuilt/Dockerfile
I'll be updating the instructions soon on that, the docker image is available pre-built on github packages here for use with 'docker pull'
https://github.com/Unit-e/esp-open-sdk-docker/pkgs/container/esp-open-sdk-docker
So you can do something like this (I have some helper scripts that make this more of a one-liner)
The big limitation to be aware of is, on WSL2 (which is what Docker Desktop on windows uses behind the scenes), serial port forwarding is broken so you can't just flash using the normal methods from inside the docker container. BUT, it's pretty simple to use pyserial's rfc2177 serial-over-ip server to deal with that:
In the makefile (or override on commandline or user.cfg), you set this:
And on the windows host you do something like this:
Then all the "make burn" etc works from inside the docker container. pyserial's "miniterm" supports connect for serial monitor like this:
I made a few forks of the various submodules that fix some build issues with the latest build based on pfalcon/esp-open-sdk. It appears to compile correctly and produce working firmware, but, I think esp82xx would be needed to be upgraded and tested to see if everything works there.
Anyway, if anyone here was ever looking to upgrade esp82xx to the latest pfalcon-based esp-open-sdk, that might be a good starting point.
Just wanted to shoutout to @cnlohr who has been a good sport about walking my n00b self through a lot of this for the first time.