invariants: fix non-inlined empty function call #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The `invariants.Sometimes()` was not being inlined even though it resolves to a `return false` when invariants aren't on. It looks like the inline decision happens before some phases of dead code elimination. This function is called in some very hot paths inside the columnar block builder. This change moves `Sometimes()` into the `on.go/off.go` files where it can be simplified for the `off` case. We also add some `invariants.Enabled` and `invariants.UseFinalizers` checks (which are constant, unlike function calls) in hot paths. ``` CockroachDataBlockWriter/AlphaLen=4,Prefix=8,Shared=2,KeysPerPrefix=2,valueLen=8-10 75.3µs ± 1% 74.4µs ± 0% -1.19% (p=0.000 n=8+8) ```
RaduBerinde
force-pushed
the
fix-sometimes-call
branch
from
966b801 to
af98899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invariants: fix non-inlined empty function call
The
invariants.Sometimes()was not being inlined even though itresolves to a
return falsewhen invariants aren't on. It looks likethe inline decision happens before some phases of dead code
elimination. This function is called in some very hot paths inside the
columnar block builder.
This change moves
Sometimes()into theon.go/off.gofiles where itcan be simplified for the
offcase. We also add someinvariants.Enabledandinvariants.UseFinalizerschecks (which areconstant, unlike function calls) in hot paths.