db: add UserKeyCategories #4210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way to configure Pebble with an informative partitioning of the
key space. Each partition is a named key category; we use these for
pprof labels.
We currently set these pprof labels for compactions. In the future, we
will allow turning on labels in the read/write paths for specific
investigations.
Sample CRDB configuration code:
```
var userKeyCategories = pebble.MakeUserKeyCategories(
EngineComparer.Compare,
[]pebble.UserKeyCategory{
{Name: "local-1", UpperBound: toEngineKey(keys.LocalRangeIDPrefix.AsRawKey())},
{Name: "rangeid", UpperBound: toEngineKey(keys.LocalRangeIDPrefix.AsRawKey().PrefixEnd())},
{Name: "local-2", UpperBound: toEngineKey(keys.LocalRangePrefix)},
{Name: "range", UpperBound: toEngineKey(keys.LocalRangePrefix.PrefixEnd())},
{Name: "local-3", UpperBound: toEngineKey(keys.LocalRangeLockTablePrefix)},
{Name: "lock", UpperBound: toEngineKey(keys.LocalRangeLockTablePrefix.PrefixEnd())},
{Name: "local-4", UpperBound: toEngineKey(keys.LocalPrefix.PrefixEnd())},
{Name: "meta", UpperBound: toEngineKey(keys.MetaMax)},
{Name: "system", UpperBound: toEngineKey(keys.SystemMax)},
{Name: "tenant"},
}...,
)
```
|
This change is |
|
Sample flame graph with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to configure Pebble with an informative partitioning of the
key space. Each partition is a named key category; we use these for
pprof labels.
We currently set these pprof labels for compactions. In the future, we
will allow turning on labels in the read/write paths for specific
investigations.
Sample CRDB configuration code: