Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo rotate animation with css #621

Merged
merged 6 commits into from
Nov 3, 2024
Merged

Conversation

vltansky
Copy link
Contributor

@vltansky vltansky commented Aug 19, 2024

@vltansky vltansky changed the title logo rotate animation with css Logo rotate animation with css Aug 19, 2024
@cocopon
Copy link
Owner

cocopon commented Nov 3, 2024

Thank you for your contribution, and sorry for the late reply...

I wasn’t aware of animation-timeline: scroll() feature. It looks useful, but it doesn’t work on some major browsers like Firefox and Safari. What do you think about this?

@vltansky
Copy link
Contributor Author

vltansky commented Nov 3, 2024

I've added fallback

@cocopon
Copy link
Owner

cocopon commented Nov 3, 2024

Great! Could you run npm run format in packages/tweakpane directory to pass the CI check?

@cocopon cocopon merged commit aa34f26 into cocopon:main Nov 3, 2024
1 check passed
@cocopon
Copy link
Owner

cocopon commented Nov 3, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants