Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added first version of Laminas integration #261

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JustInVTime
Copy link

No description provided.

@JustInVTime
Copy link
Author

Apparently you cannot install Laminas next to deprecated Zend Framework packages.
What about removing the deprecated ZF2 integration in new releases?

* @subpackage bridge
* @license http://www.opensource.org/licenses/MIT The MIT License
*/
class Module implements ServiceProviderInterface, ViewHelperProviderInterface

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make an update of the ZF / Laminas bridge then the support should also be extended for Mezzio (formerly Expressive).
This means to create a module class to support a MVC based application and to create a config-provider class to support a Mezzio based application.

Examples can be found in laminas-db:

As you can see, the module class consumes the configuration from config-provider class.

* @subpackage bridge
* @license http://www.opensource.org/licenses/MIT The MIT License
*/
class SlugifyService implements FactoryInterface

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a filter here instead of a service because this package provides a conversion / transformation of (string) data.
To create a custom filter please have a look at the official documentation of laminas-filter: "Writing Filters"

@@ -335,6 +335,53 @@ You can then use the `Slugify::slugify()` method in your controllers:
$url = Slugify::slugify('welcome to the homepage');
```

### Laminas

Slugify can be easely used in Laminas applications. Included bridge provides a service and a view helper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easily...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants