Fix permissions issue with tests #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeds to get told that we're passing arguments to the target binary, not to itself
|
Thanks so much for this! Just waiting for a full test run, will merge soon after |
Merged
|
@libmartinito looks like the recent depot.dev changes result in tests not running for PRs from forks - could you look into this please? For now I've cherry-picked the commit from here and onto #96 |
|
Merged in #96 - will keep open so we can investigate the issue with PRs to forks not building |
|
Updated with a new commit. I managed to introduce a typo even into this tiny patch (sigh) |
rohitpaulk
changed the title
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing a Rust project, the usual way to run the target binary would be
cargo run. The current template does that, passing a number of other arguments (silent build, etc.)There's a problem when trying to go through the extension (RDB access) though. Cargo is able to pass arguments to the target, but it needs to be told where its own arguments end. As is, the
This PR fixes the problem.