Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving exceptions from private to public functions #3

Open
wimulkeman opened this issue Dec 9, 2015 · 0 comments
Open

Moving exceptions from private to public functions #3

wimulkeman opened this issue Dec 9, 2015 · 0 comments
Assignees
@wimulkeman
Labels
enhancement
Milestone
1.2.0

Comments

@wimulkeman
Copy link
Member

In a couple of places, an private method throws an exception when the provided argument is invalid. This should be moved to the public function which requests the private function. On this level the argument itself should be thoroughly tested.
@wimulkeman wimulkeman self-assigned this Dec 9, 2015
@wimulkeman wimulkeman added this to the 1.2.0 milestone Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wimulkeman wimulkeman

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@wimulkeman