hsvtt: Add eslint support; fix most findings #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds eslint support to the project. That includes an eslintrc file that is based on the Airbnb standard, as well as an eslintignore file. This patch opts for an ES5 'legacy' standard, as the lack of a transpiler for the front-end Javascript code prevents using ES6. A few warnings and errors have been left unresolved. These include: * A single console statement indicating that the app is running. This should be replaced with a logger, such a bunyan. * A few references to undefined variables. The intent of this function could not be determined, nor how it functioned. * An unused variable 'orderedStops', which appears to either have no purpose or should be the variable that is returned from a particular function. It's important to note that despite the scope of the changes, no semantic changes should have been introduced in this patch. However, given the scope of the changes, significant testing should be done before deploying the results of this patch into a production environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds eslint support to the project. That includes an eslintrc file
that is based on the Airbnb standard, as well as an eslintignore file. This
patch opts for an ES5 'legacy' standard, as the lack of a transpiler for the
front-end Javascript code prevents using ES6.
A few warnings and errors have been left unresolved. These include:
be replaced with a logger, such a bunyan.
not be determined, nor how it functioned.
or should be the variable that is returned from a particular function.
It's important to note that despite the scope of the changes, no semantic
changes should have been introduced in this patch. However, given the scope of
the changes, significant testing should be done before deploying the results
of this patch into a production environment.