refactor: review github CI on PHP8.4

codeigniter4 · Nov 5, 2024 · 288c05f · 288c05f
1 parent fff0c87
commit 288c05f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 14 deletions.
diff --git a/.github/workflows/reusable-phpunit-test.yml b/.github/workflows/reusable-phpunit-test.yml
@@ -203,7 +203,6 @@ jobs:
           DB: ${{ inputs.db-platform }}
           TACHYCARDIA_MONITOR_GA: ${{ inputs.enable-profiling && 'enabled' || '' }}
           TERM: xterm-256color
-        continue-on-error: ${{ inputs.php-version == '8.4' }}
 
       - name: Upload coverage results as artifact
         if: ${{ inputs.enable-artifact-upload }}

diff --git a/.github/workflows/test-coding-standards.yml b/.github/workflows/test-coding-standards.yml
@@ -29,7 +29,7 @@ jobs:
       matrix:
         php-version:
           - '8.1'
-          - '8.3'
+          - '8.4'
 
     steps:
       - name: Checkout

diff --git a/.github/workflows/test-phpunit.yml b/.github/workflows/test-phpunit.yml
@@ -59,9 +59,7 @@ jobs:
           - '8.1'
           - '8.2'
           - '8.3'
-        include:
-          - php-version: '8.4'
-            composer-option: '--ignore-platform-req=php'
+          - '8.4'
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:
@@ -88,6 +86,7 @@ jobs:
           - '8.1'
           - '8.2'
           - '8.3'
+          - '8.4'
         db-platform:
           - MySQLi
           - OCI8
@@ -100,8 +99,6 @@ jobs:
           - php-version: '8.1'
             db-platform: MySQLi
             mysql-version: '5.7'
-          - php-version: '8.4'
-            composer-option: '--ignore-platform-req=php'
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:
@@ -129,9 +126,7 @@ jobs:
           - '8.1'
           - '8.2'
           - '8.3'
-        include:
-          - php-version: '8.4'
-            composer-option: '--ignore-platform-req=php'
+          - '8.4'
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:
@@ -157,9 +152,7 @@ jobs:
           - '8.1'
           - '8.2'
           - '8.3'
-        include:
-          - php-version: '8.4'
-            composer-option: '--ignore-platform-req=php'
+          - '8.4'
 
     uses: ./.github/workflows/reusable-phpunit-test.yml # @TODO Extract to codeigniter4/.github repo
     with:

diff --git a/.github/workflows/test-rector.yml b/.github/workflows/test-rector.yml
@@ -45,7 +45,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['8.1', '8.3']
+        php-versions: ['8.1', '8.4']
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,7 +29,7 @@ jobs: @@
           matrix:
             php-version:
               - '8.1'
-              - '8.3'
+              - '8.4'
         steps:
           - name: Checkout
@@ Expand Down @@