Remove deployment ID, add IDisposable

codemonkey85 · Dec 4, 2024 · 92d7ecc · 92d7ecc
1 parent fbc9667
commit 92d7ecc
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 19 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -13,12 +13,6 @@ jobs:
       # uses GitHub's checkout action to checkout code form the main branch
       - uses: actions/[email protected]
 
-      - name: UpdateVersionInMainLayout
-        uses: datamonsters/replace-action@v2
-        with:
-          files: 'Pkmds.Web/Components/Layout/MainLayout.razor.cs'
-          replacements: '%%CACHE_VERSION%%=${{ github.run_id }}'
-
       # sets up .NET SDK
       - name: Setup .NET Core SDK
         uses: actions/[email protected]

diff --git a/Pkmds.Web/Components/Layout/MainLayout.razor b/Pkmds.Web/Components/Layout/MainLayout.razor
@@ -113,10 +113,6 @@
                 Special thanks to Kaphotics, as well as <MudLink Href="https://github.com/kwsch/PKHeX/graphs/contributors"
                                                                  Target="_blank">all the contributors to PKHeX and PKHeX.Core</MudLink>.
             </MudText>
-            <MudText>
-                Deployment ID: <MudLink Href="@($"https://github.com/codemonkey85/PKMDS-Blazor/actions/runs/{DeploymentId}")"
-                                        Target="_blank">@DeploymentId</MudLink>
-            </MudText>
         </MudStack>
     </MudDrawer>
     <MudMainContent>

diff --git a/Pkmds.Web/Components/Layout/MainLayout.razor.cs b/Pkmds.Web/Components/Layout/MainLayout.razor.cs
@@ -5,9 +5,6 @@ public partial class MainLayout : IDisposable
     private bool isDarkMode;
     private MudThemeProvider? mudThemeProvider;
 
-
-    private const string DeploymentId = "%%CACHE_VERSION%%";
-
     protected override void OnInitialized() => RefreshService.OnAppStateChanged += StateHasChanged;
 
     public void Dispose() => RefreshService.OnAppStateChanged -= StateHasChanged;

diff --git a/Pkmds.Web/Components/LetsGoBoxComponent.razor.cs b/Pkmds.Web/Components/LetsGoBoxComponent.razor.cs
@@ -1,6 +1,6 @@
 namespace Pkmds.Web.Components;
 
-public partial class LetsGoBoxComponent
+public partial class LetsGoBoxComponent : IDisposable
 {
     public BoxEdit? BoxEdit { get; set; }
 

diff --git a/Pkmds.Web/Components/MarkingsContainer.razor.cs b/Pkmds.Web/Components/MarkingsContainer.razor.cs
@@ -1,6 +1,6 @@
 namespace Pkmds.Web.Components;
 
-public partial class MarkingsContainer
+public partial class MarkingsContainer : IDisposable
 {
     [Parameter, EditorRequired]
     public PKM? Pokemon { get; set; }

diff --git a/Pkmds.Web/Components/Pages/Home.razor.cs b/Pkmds.Web/Components/Pages/Home.razor.cs
@@ -1,6 +1,6 @@
 namespace Pkmds.Web.Components.Pages;
 
-public partial class Home
+public partial class Home : IDisposable
 {
     private bool IsUpdateAvailable { get; set; } = false;
 

diff --git a/Pkmds.Web/Components/PartyGrid.razor.cs b/Pkmds.Web/Components/PartyGrid.razor.cs
@@ -1,6 +1,6 @@
 namespace Pkmds.Web.Components;
 
-public partial class PartyGrid
+public partial class PartyGrid : IDisposable
 {
     private void SetSelectedPokemon(PKM? pokemon, int slotNumber) =>
         AppService.SetSelectedPartyPokemon(pokemon, slotNumber);

diff --git a/Pkmds.Web/Components/PokemonSlotComponent.razor.cs b/Pkmds.Web/Components/PokemonSlotComponent.razor.cs
@@ -1,6 +1,6 @@
 namespace Pkmds.Web.Components;
 
-public partial class PokemonSlotComponent
+public partial class PokemonSlotComponent : IDisposable
 {
     [Parameter, EditorRequired]
     public int SlotNumber { get; set; }

diff --git a/Pkmds.Web/Services/BlazorAesProvider.cs b/Pkmds.Web/Services/BlazorAesProvider.cs
@@ -8,7 +8,7 @@ public IAesCryptographyProvider.IAes Create(byte[] key, CipherMode mode, Padding
 #pragma warning disable CS9113 // Parameter is unread.
     private class CryptoJsAes(JsService jsService, byte[] key, CipherMode mode, PaddingMode padding, byte[]? iv = null)
 #pragma warning restore CS9113 // Parameter is unread.
-        : IAesCryptographyProvider.IAes
+        : IAesCryptographyProvider.IAes, IDisposable
     {
         public void EncryptEcb(ReadOnlySpan<byte> plaintext, Span<byte> destination) =>
             jsService.EncryptAes(plaintext, destination, key, CipherMode.ECB);