[FE] 코드 리팩토링, ui 작업 및 사운드 효과 추가 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 주식 칸에 도착했을 때 랜더링
silvertae
approved these changes
Nov 3, 2023
fe/src/assets/images/gs.png
Outdated
There was a problem hiding this comment.
와 저도 이거 거슬렸는데 귀찮아서 미뤘는데 토코가 깔끔하게 배경제거해주셨군요. 토코 짱짱맨!
Comment on lines
+33
to
+39
| <IconContainer | ||
| className="status-board" | ||
| onClick={toggleStatusBoardModal} | ||
| > | ||
| <Icon name="statusBoard" size="3rem" color="neutralText" /> | ||
| </IconContainer> | ||
| <Navigation> |
There was a problem hiding this comment.
지금 현황판 버튼 위치가 뭔가 게임보드판 중앙이라 딱 안 맞아서 약간 신경쓰이네요. 👀
margin-right를 조금만 주면 맞출수 있을것 같기도...? 한 74~5px 정도 주니까 얼추 맞는것 같긴하네요.
fe/src/hooks/useSound.tsx
Outdated
| setGameInfo((prev) => { | ||
| return { | ||
| ...prev, | ||
| isArrived: false, |
There was a problem hiding this comment.
주식매수창이 닫혔을때 isArrived: false로 바꿔주는건 한 번 닫히면 다시 안열리게 하기 위함인가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈번호
🔑 Key changes
2023-11-03.7.07.16.mov
👋 To reviewers