Make array field adapter independent from the connection. #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the field does not depend on the database OIDs, calling
prepare()
is not necessary. This is also mentioned in the docs1. The reason this is not dependent on the connection since we don't try to adapt any special OIDs that can vary from one Postgres version to another.We discovered this when a wrapped connection was used to adapt the new type.
Relevant: opbeat/opbeat_python#68
Thanks in advance for reviewing this.