Add ARM64 support for Docker images #951
Conversation
Related to comet-ml#696 Add support for multi-architecture builds for Opik frontend and backend images. * Update `apps/opik-backend/Dockerfile` and `apps/opik-frontend/Dockerfile` to include `--platform` flag for multi-architecture builds. * Modify `.github/workflows/build_and_push_docker.yaml` to include `--platform` flag in the `docker build` and `docker push` commands. * Update `deployment/docker-compose/docker-compose.yaml` and `deployment/docker-compose/docker-compose.override.yaml` to specify `platform: linux/amd64,linux/arm64` for `backend` and `frontend` services. * Update `deployment/docker-compose/README.md` to include instructions for multi-architecture builds. Pending task build_apps.yaml Docker push & build Linux support arm AMD
|
@vishwamartur Thanks for the PR, @liyaka will take a look on Sunday |
|
Hi @vishwamartur - it's not running on linux - please see one of the failed workflows: |
There was a problem hiding this comment.
@vishwamartur thanks for taking the time to submit this pull request. we are working internally to achieve this and will submit a followup PR from our team. im closing this for now and will ping you soon once we open the new PR
| @@ -113,6 +114,7 @@ services: | |||
| depends_on: | |||
| backend: | |||
| condition: service_started | |||
| platform: linux/amd64,linux/arm64 | |||
There was a problem hiding this comment.
we will add platform as optional in docker-compose-override only if needed
please remove
| @@ -97,6 +97,7 @@ services: | |||
| condition: service_healthy | |||
| clickhouse: | |||
| condition: service_healthy | |||
| platform: linux/amd64,linux/arm64 | |||
There was a problem hiding this comment.
we will add platform as optional in docker-compose-override only if needed
please remove
| @@ -16,7 +16,9 @@ services: | |||
| ports: | |||
| - "8080:8080" # Exposing backend HTTP port to host | |||
| - "3003:3003" # Exposing additional backend port to host | |||
| platform: linux/amd64,linux/arm64 | |||
There was a problem hiding this comment.
This should be optional, only adding an example in docker-compose/README.md file
please remove
|
|
||
| frontend: | ||
| ports: | ||
| - "5173:5173" # Exposing frontend dev server port to host | ||
| platform: linux/amd64,linux/arm64 |
There was a problem hiding this comment.
This should be optional, only adding an example in docker-compose/README.md file
please remove
| @@ -50,7 +50,14 @@ This will expose the following services to the host machine | |||
| - MySQL: Available on port 3306 | |||
| - Backend: Available on ports 8080 and 3003 | |||
|
|
|||
| ## Multi-Architecture Builds | |||
There was a problem hiding this comment.
| ## Multi-Architecture Builds | |
| ## Run locally on different architectures (arm/amd) |
|
|
||
| To build the Opik frontend and backend images for both `linux/amd64` and `linux/arm64` architectures, you can use the following command: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
we will override in docker-compose please remove
| @@ -1,5 +1,5 @@ | |||
| # Build stage | |||
| FROM node:20.15.0-alpine3.20 as builder | |||
| FROM --platform=linux/amd64,linux/arm64 node:20.15.0-alpine3.20 as builder | |||
There was a problem hiding this comment.
I dont think multiple platforms are supported here.
we will add this to the build and push job. please remove
| @@ -17,7 +17,7 @@ ARG BUILD_MODE=production | |||
| RUN npm run build -- --mode $BUILD_MODE | |||
|
|
|||
| # Production stage | |||
| FROM nginx:1.27.3-alpine3.20 | |||
| FROM --platform=linux/amd64,linux/arm64 nginx:1.27.3-alpine3.20 | |||
There was a problem hiding this comment.
I dont think multiple platforms are supported here.
we will add this to the build and push job. please remove
| @@ -12,7 +12,7 @@ RUN mvn versions:set -DnewVersion=${OPIK_VERSION} && \ | |||
| mvn clean package -DskipTests | |||
|
|
|||
| ############################### | |||
| FROM amazoncorretto:21-al2023 | |||
| FROM --platform=linux/amd64,linux/arm64 amazoncorretto:21-al2023 | |||
There was a problem hiding this comment.
I dont think multiple platforms are supported here.
we will add this to the build and push job. please remove
| @@ -1,4 +1,4 @@ | |||
| FROM maven:3.9.9-amazoncorretto-21-al2023 AS build | |||
| FROM --platform=linux/amd64,linux/arm64 maven:3.9.9-amazoncorretto-21-al2023 AS build | |||
There was a problem hiding this comment.
I dont think multiple platforms are supported here.
we will add this to the build and push job. please remove
Related to #696
Add support for multi-architecture builds for Opik frontend and backend images.
apps/opik-backend/Dockerfileandapps/opik-frontend/Dockerfileto include--platformflag for multi-architecture builds..github/workflows/build_and_push_docker.yamlto include--platformflag in thedocker buildanddocker pushcommands.deployment/docker-compose/docker-compose.yamlanddeployment/docker-compose/docker-compose.override.yamlto specifyplatform: linux/amd64,linux/arm64forbackendandfrontendservices.deployment/docker-compose/README.mdto include instructions for multi-architecture builds.Pending task build_apps.yaml
Docker push & build
Linux support arm AMD