Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish author viewpoint page #11

Open
wants to merge 14 commits into
base: development
Choose a base branch
from
Open

Conversation

yukicoder0509
Copy link
Collaborator

I have finished author-viewpoint page and fixed some center layout problems and adjust the height setting of each page.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 4:58pm

src/app/issues/[id]/author/page.tsx Outdated Show resolved Hide resolved
src/app/issues/[id]/author/page.tsx Outdated Show resolved Hide resolved
src/app/issues/[id]/author/page.tsx Outdated Show resolved Hide resolved
src/app/issues/[id]/author/page.tsx Outdated Show resolved Hide resolved
src/components/AuthorViewpoint/FactCard.tsx Outdated Show resolved Hide resolved
src/components/AuthorViewpoint/FactCard.tsx Outdated Show resolved Hide resolved
src/components/AuthorViewpoint/FactCard.tsx Outdated Show resolved Hide resolved
src/components/AuthorViewpoint/ViewpointCard.tsx Outdated Show resolved Hide resolved
@burnedinthesky
Copy link
Contributor

In addition, per the design file, please remember to add a 6px padding between paragraphs.

Copy link
Contributor

@burnedinthesky burnedinthesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All previous issues have been resolved except for the paragraph spacing. By paragraph spacing I mean additional padding between paragraphs of text (created by pressing the enter key). Paragraph spacing should be in addition to line height. For example: the distance between text "Line 1 \n Line 2" should be 6px more than "Line 1..... [line-wrap] line 2".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants