Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcl: modernize + simplify cmake patch #8873

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 12, 2022

Specify library name and version: lib/1.0

When fcl was packaged the first time, imported targets of eigen, libccd and octomap were not properly modeled in cmake_find_package_* generators, leading to this ugly patch. Now it's far better and the patch can be simplified.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jan 12, 2022

I detected other pull requests that are modifying fcl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jan 12, 2022
4 tasks
@SpaceIm SpaceIm changed the title fcl: modernize & simplify cmake patch fcl: add 0.7.0 + modernize + simplify cmake patch Jan 12, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 12, 2022

I've submitted the CMake patch upstream:
flexible-collision-library/fcl#559
flexible-collision-library/fcl#560

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jan 17, 2022
@SpaceIm SpaceIm changed the title fcl: add 0.7.0 + modernize + simplify cmake patch fcl: modernize + simplify cmake patch Jan 21, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 4 (b5cc9bfaf7fe72dec98f6342f3de948684f72c72):

  • fcl/0.7.0@:
    All packages built successfully! (All logs)

  • fcl/0.6.1@:
    All packages built successfully! (All logs)

@SpaceIm SpaceIm requested a review from uilianries January 21, 2022 09:03
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 22d2f54 into conan-io:master Jan 25, 2022
@SpaceIm SpaceIm deleted the fcl-modernize branch January 25, 2022 10:14
Sahnvour pushed a commit to Sahnvour/conan-center-index that referenced this pull request Jan 30, 2022
* modernize

* bump eigen & octomap

* add fcl/0.7.0

* cleanup after merge of master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants