Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to wasm32-wasip1 target #753

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Nov 26, 2024

Rust 1.81.0 now issues a warning for the usage of wasm32-wasi target and suggests users to switch to wasm32-wasip1 target. Since we have bumped the minimal rustc version to 1.81.0 in rust-toolchain.toml, we should switch to this new target.

This commit does a whole replace of 'wasm32-wasi -> wasm32-wasip1'.

Rust 1.81.0 now issues a warning for the usage of wasm32-wasi target and suggests
users to switch to wasm32-wasip1 target. Since we have bumped the minimal rustc version
to 1.81.0 in rust-toolchain.toml, we should switch to this new target.

This commit does a whole replace of 'wasm32-wasi -> wasm32-wasip1'.

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes jprendes merged commit 1b0ef20 into containerd:main Nov 26, 2024
71 checks passed
@Mossaka Mossaka deleted the wasip1 branch November 26, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants