Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use safe number parsing #501

Merged
merged 3 commits into from
Dec 3, 2023
Merged

fix: Use safe number parsing #501

merged 3 commits into from
Dec 3, 2023

Conversation

jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Dec 3, 2023 •
edited
Loading

Motivation & Context:

reason/motivation behind the PR, context of what problem it solves
This PR solves the issue #issue

Description:

describe the change briefly

Types of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@jay-dee7 jay-dee7 self-assigned this Dec 3, 2023
@jay-dee7
fix: CodeQL action
f7205b2 
Signed-off-by: jay-dee7 <[email protected]>
@jay-dee7 jay-dee7 force-pushed the fix/codesql-suggestions branch 2 times, most recently from c13f584 to 223a3fe Compare December 3, 2023 16:51
@jay-dee7 jay-dee7 marked this pull request as ready for review December 3, 2023 18:11
@jay-dee7 jay-dee7 requested a review from guacamole as a code owner December 3, 2023 18:11
@jay-dee7 jay-dee7 added the Security Security enhancement related work label Dec 3, 2023
@jay-dee7 jay-dee7 force-pushed the fix/codesql-suggestions branch from 223a3fe to 918d804 Compare December 3, 2023 18:15
@jay-dee7 jay-dee7 force-pushed the fix/codesql-suggestions branch from 918d804 to 73240ee Compare December 3, 2023 18:20
guacamole
guacamole approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅

@guacamole guacamole merged commit 5191a19 into main Dec 3, 2023
10 checks passed
@guacamole guacamole deleted the fix/codesql-suggestions branch December 3, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacamole guacamole guacamole approved these changes

Assignees

@jay-dee7 jay-dee7

Labels
Security Security enhancement related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-dee7 @guacamole