Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeQL recommendations #750

Merged
merged 2 commits into from
Aug 31, 2024
Merged

fix: CodeQL recommendations #750

merged 2 commits into from
Aug 31, 2024

Conversation

jay-dee7
Copy link
Member

@jay-dee7 jay-dee7 commented Aug 31, 2024

Motivation & Context:

In our mock FS implementations (File based and In-Memory based), we were not validating file input paths. CodeQL keeps on complaining about the paths, so now we just validate the paths before performing actions using file path inputs

Description:

  • Validate paths ensuring they always start with layers.
  • Also bumps the Bun ORM dependencies to latest

Types of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@jay-dee7 jay-dee7 requested a review from guacamole as a code owner August 31, 2024 10:40
@jay-dee7 jay-dee7 self-assigned this Aug 31, 2024
@jay-dee7 jay-dee7 force-pushed the fix/code-ql-recommendations branch from d901a3f to 43c069a Compare August 31, 2024 10:45
@jay-dee7 jay-dee7 changed the title Fix/code ql recommendations fix: CodeQL recommendations Aug 31, 2024
@jay-dee7 jay-dee7 force-pushed the fix/code-ql-recommendations branch from 43c069a to 0b55dbd Compare August 31, 2024 10:47
Copy link
Member

@guacamole guacamole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@guacamole guacamole merged commit 1e2876d into main Aug 31, 2024
10 checks passed
@guacamole guacamole deleted the fix/code-ql-recommendations branch August 31, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants