Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm/kustomize: fix configmaps #104

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

poussa
Copy link
Contributor

@poussa poussa commented Aug 15, 2023

Fixes #103

@fmuyassarov
Copy link
Collaborator

Thanks. Can you please fix the same issue for kustomize configMaps too?
For example:

@poussa poussa changed the title helm: include filename in configmap include filename in configmaps Aug 15, 2023
@poussa poussa changed the title include filename in configmaps helm/kustomize: fix configmaps Aug 15, 2023
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from one question.

Signed-off-by: Sakari Poussa <[email protected]>
Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov
Copy link
Collaborator

/cc @klihub

@klihub klihub merged commit ccfa36a into containers:main Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm install fails due to missing config file
3 participants