-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm/kustomize: fix configmaps #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks. Can you please fix the same issue for kustomize configMaps too? |
poussa
force-pushed
the
helm-config-file
branch
from
August 15, 2023 11:22
c061665
to
669ce96
Compare
poussa
changed the title
helm: include filename in configmap
include filename in configmaps
Aug 15, 2023
Signed-off-by: Sakari Poussa <[email protected]>
poussa
force-pushed
the
helm-config-file
branch
from
August 15, 2023 12:10
669ce96
to
c28c301
Compare
fmuyassarov
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from one question.
deployment/helm/resource-management-policies/topology-aware/values.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Sakari Poussa <[email protected]>
poussa
force-pushed
the
helm-config-file
branch
from
August 16, 2023 08:00
fc92615
to
ba0cbbc
Compare
fmuyassarov
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @klihub |
klihub
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103