build: update to controller-tools 0.14.0. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Built-in "reserved" and "default" balloon types are no longer special cases. They can be configured with the same parameters as user-defined balloons. Before this change their configuration was limited to few parameters. - The reserved balloon inflates and deflates if required by containers and allowed by minCPUs and maxCPUs. - Default balloons (which can be numerous now) never share CPUs with the reserved balloon. - Overcommitting reserved CPU resources is no more possible. Creating reserved containers will fail if there are not enough CPUs in the reserved balloon. - Explicit ReservedResources cpuset no more defines exactly the CPUs allocated to the reserved balloon. Instead, they are strongly preferred for that purpose. This happens implicitly through the same mechanism as explicit preferCloseToDevices. - Fixes: AllocatorPriority did not have proper effect. Now it enables high-priority user-defined balloons to allocate CPUs even before the reserved balloon. - Fixes: AvailableResources and ReservedResources had effect only when the policy was started, but not on reconfiguration. Now they can be changed in reconfiguration. Signed-off-by: Antti Kervinen <[email protected]>
In addition to testing resising the reserved balloon, the basic placement test is changed because it relied on overcommitting reserved CPUs. Signed-off-by: Antti Kervinen <[email protected]>
This was referenced Feb 12, 2024
Update controller-tools to 0.14.0. It handles some errors better than simply throwing a panic, leaving the user with little to no hint about what is really wrong. Regenerate CRDs since this version also generates multiline YAML strings differently than 0.12.0. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/update-controller-tools
branch
from
76a7531 to
def905b
Compare
|
But let's wait for #254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update controller-tools to 0.14.0. It handles some errors better than simply throwing a panic, leaving the user with little to no hint about what is really wrong. Regenerate CRDs since this version also generates multiline YAML strings differently than 0.12.0.