helm: flip podPriorityClassNodeCritical to true. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `podPriorityClassNodeCritical` to true by default, adding plugins to the `system-node-critical` priority class. This should mitigate the potential risk of a plugin getting evicted under heavy system load. It should also ensure that during autoscaling enough new nodes are brought up to leave room for plugins on each new node. Signed-off-by: Krisztian Litkey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
podPriorityClassNodeCriticalto true by default, adding plugins to thesystem-node-criticalpriority class. This should mitigate the potential risk of a plugin getting evicted under heavy system load. It should also ensure that during autoscaling enough new nodes are brought up to leave room for plugins on each new node.