config-manager: allow configuring NRI timeouts. #318
Conversation
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
from
7cd6cf4 to
b19dce3
Compare
|
@fmuyassarov Looking at the updated docs, one question immediately came to my mind related to the updated helm charts. Considering the new timeout values in |
Yes, makes sense. That way we are more consistent indeed. I would also rather rename word patch to something more descriptive but at the same time I don't have a good suggestion to offer :) UPDATE: A slight problem (if we can really call it a problem) is that adding .config. makes it more deeper which might be something that users don't like. But that might be not be true really. Just thinking out loud. |
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
3 times, most recently
from
3a7af7c to
9a3fbc0
Compare
Yes, I had the reaction when updating the daemonset files with templating conditionals. I still decided to stick with it for consistency. |
|
@fmuyassarov @askervin I fixed a few gotchas we neither noticed nor thought of. Fixed those after testing this in a cluster. I'd consider it a good enough first try unless you guys spot something I still missed. |
Allow setting NRI plugin registration and request timeouts in the CRI-O or containerd configuration files. Require neither or both timeouts to be given. If both are given, verify that registration timeout is larger than the request timeout. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
from
9a3fbc0 to
a1ed304
Compare
|
@fmuyassarov @askervin It would be nice if we could enforce with the values JSON schema that either both or neither configuration timeout parameters should be set. But I suspect the schema might not be able to express such dependencies... |
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
from
a1ed304 to
b4fde25
Compare
Update all plugin Helm charts, to allow the config-manager to
patch plugin registration and request timeouts in the runtime
configuration.
Aiming for more consistent value structure by switching from
these NRI-related bits:
nri:
patchRuntimeConfig: false
pluginIndex: 90
to these new ones:
nri:
plugin:
index: 90
runtime:
patchConfig: false
config:
pluginRegistrationTimeout: 5s
pluginRequestTimeout: 2s
There would be room for further later improvements by moving
the bits for enabling plugin test APIs to nri.plugin, too...
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
from
b4fde25 to
843bf29
Compare
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
from
843bf29 to
05d3d66
Compare
Update runtime config patching bits in CRD. Signed-off-by: Krisztian Litkey <[email protected]>
Update to use updated Values.nri.runtime.patchConfig instead of Values.nri.patchRuntimeConfig. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/config-manager/nri-plugin-timeouts
branch
from
05d3d66 to
d63bba3
Compare
Allow setting NRI plugin registration and request timeouts in the CRI-O or containerd configuration files. Require neither or both timeouts to be given. If both are given, verify that registration timeout is larger than the request timeout.