Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces asyncio timeout with bespoke timeout function #858

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

breca
Copy link
Contributor

@breca breca commented Feb 26, 2024

As per title, replaces asyncio.timeout function with a bespoke timeout function.

In conjunction with this PR this satisfies all but 3.8 test criteria.

image

Compiling 'podman_compose.py'...
************* Module podman_compose
podman_compose.py:2259:8: C0103: Variable name "s" doesn't conform to snake_case naming style (invalid-name)
podman_compose.py:2377:12: E1123: Unexpected keyword argument 'name' in function call (unexpected-keyword-arg)
podman_compose.py:2442:12: E1123: Unexpected keyword argument 'name' in function call (unexpected-keyword-arg)

-----------------------------------
Your code has been rated at 9.94/10

I wrote this before seeing that there was work being done in devel-asyncio, understand you're probably taking a different direction so feel free to ignore, but I already did the work so I thought I'd at least offer it. 😆

@breca
Copy link
Contributor Author

breca commented Mar 8, 2024

Cleaner approach in #869

Closing

@breca breca closed this Mar 8, 2024
@p12tic p12tic mentioned this pull request Mar 8, 2024
@p12tic
Copy link
Collaborator

p12tic commented Mar 8, 2024

@breca I actually think that this PR is a better approach because it doesn't introduce an additional dependency. Since some people will want to use podman-compose as standalone script, the number of dependencies should be minimized.

@p12tic p12tic reopened this Mar 8, 2024
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! The PR just needs a rebase.

@p12tic p12tic merged commit dcb6cdb into containers:main Mar 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants