-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: name filter in images.list() #468
Conversation
49c7fec
to
c424994
Compare
@umohnani8 @jwhonce @inknos PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Mr-Sunglasses thanks for the PR. it looks good although there are a few things that the CI is complaining about, I can take a look into these as they seem unrelated.
The PR is good. Would you like to write some tests for filter?
You can take inspiration from these prs #462 #460 and if you have questions I can help you if you need
0b0659c
to
e55adf8
Compare
Signed-off-by: Kanishk Pachauri <[email protected]>
Signed-off-by: Kanishk Pachauri <[email protected]>
Signed-off-by: Kanishk Pachauri <[email protected]>
Signed-off-by: Kanishk Pachauri <[email protected]>
Signed-off-by: Kanishk Pachauri <[email protected]>
d271cdd
to
986ba47
Compare
Thanks a lot @inknos for the suggestions, I've added the tests for the filter and they are passing. Also, I investigate on why the test's are failing, the reason seems for the test's failing, Thanks again, Looking forward to contribute more to the project! |
|
whops, I missed your first update, sorry.
Agree. it's been a topic for a while, but I think the times are mature now and we can drop these versions from upstream Let's proceed this way: I will make a pr to drop python and fix the tests, then we can merge this and also I'll bundle your changes in 5.3.0 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, Mr-Sunglasses The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4c1490f
into
containers:main
fix: #457