fix: name filter in images.list()

[Mr-Sunglasses]

fix: #457

[rhatdan]

@umohnani8 @jwhonce @inknos PTAL

[inknos]

hey @Mr-Sunglasses thanks for the PR. it looks good although there are a few things that the CI is complaining about, I can take a look into these as they seem unrelated.

The PR is good. Would you like to write some tests for filter?

You can take inspiration from these prs #462 #460 and if you have questions I can help you if you need

[Mr-Sunglasses]

hey @Mr-Sunglasses thanks for the PR. it looks good although there are a few things that the CI is complaining about, I can take a look into these as they seem unrelated.

The PR is good. Would you like to write some tests for filter?

You can take inspiration from these prs #462 #460 and if you have questions I can help you if you need

Thanks a lot @inknos for the suggestions, I've added the tests for the filter and they are passing.

Also, I investigate on why the test's are failing, the reason seems for the test's failing, The code is not compatible with Python 3.6 , I think we should drop the support of python 3.6 as I no longer support by Python Team IMO we should drop 3.6, 3.7, 3.8 ( Ref. Python unsupported-versions I'm looking forward to your views on this topic.

Thanks again, Looking forward to contribute more to the project!

[Mr-Sunglasses]

hey @Mr-Sunglasses thanks for the PR. it looks good although there are a few things that the CI is complaining about, I can take a look into these as they seem unrelated.

The PR is good. Would you like to write some tests for filter?

You can take inspiration from these prs #462 #460 and if you have questions I can help you if you need

Thanks a lot @inknos for the suggestions, I've added the tests for the filter and they are passing.

Also, I investigate on why the test's are failing, the reason seems for the test's failing, The code is not compatible with Python 3.6 , I think we should drop the support of python 3.6 as I no longer support by Python Team IMO we should drop 3.6, 3.7, 3.8 ( Ref. Python unsupported-versions I'm looking forward to your views on this topic.

Thanks again, Looking forward to contribute more to the project!

cc. @rhatdan @inknos

[inknos]

whops, I missed your first update, sorry.

Also, I investigate on why the test's are failing, the reason seems for the test's failing, The code is not compatible with Python 3.6 , I think we should drop the support of python 3.6 as I no longer support by Python Team IMO we should drop 3.6, 3.7, 3.8 ( Ref. Python unsupported-versions I'm looking forward to your views on this topic.

Agree. it's been a topic for a while, but I think the times are mature now and we can drop these versions from upstream

Let's proceed this way: I will make a pr to drop python and fix the tests, then we can merge this and also I'll bundle your changes in 5.3.0

[inknos]

@jwhonce this PR has test issues that are unrelated to the code. This PR is dropping py<3.8 and bumping the release to 5.3.0, and it's a fix.

However, I'd like to see this merged first to include it in the release. Are you ok with me merging, bypassing protections?

[inknos]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, Mr-Sunglasses

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inknos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment