Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/ffi: add test checking /sys is read-only #665

Merged
merged 2 commits into from
Nov 27, 2024
Merged

tests/ffi: add test checking /sys is read-only #665

merged 2 commits into from
Nov 27, 2024
+57 −0

Conversation

aesteve-rh
Copy link
Collaborator

Test to ensure that /sys is read-only inside the
QM container.

@Yarboa
Copy link
Collaborator

Yarboa commented Nov 26, 2024

It seems that test is failing
https://artifacts.dev.testing-farm.io/d64d0683-89c7-4295-9cdf-121b7c21b981/work-ffi1ofe9kw2/plans/e2e/ffi/execute/data/guest/default-0/tests/ffi/sys_read_only-20/output.txt

And fedora failure is not related to PR, see #666

Yarboa
Yarboa reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengshanyu can you please review?

@aesteve-rh
Copy link
Collaborator Author

It seems that test is failing
https://artifacts.dev.testing-farm.io/d64d0683-89c7-4295-9cdf-121b7c21b981/work-ffi1ofe9kw2/plans/e2e/ffi/execute/data/guest/default-0/tests/ffi/sys_read_only-20/output.txt

Interesting, folder is there with right permissions. It seems that the podman exec is not doing the right thing. I'd say I tested yesterday, but I'll try again. Maybe it needs -t parameter, or /bin/sh -c 'test ..', or both.

@aesteve-rh
tests/ffi: add test checking /sys is read-only
029685c 
Test to ensure that /sys is read-only inside the
QM container.

Signed-off-by: Albert Esteve <[email protected]>
@aesteve-rh
Copy link
Collaborator Author

Looks like the error is gone, the failing test is unrelated?

Yarboa
Yarboa approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dougsland
dougsland approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failure not related. It seems related to podman issue Yariv and Giuseppe are working.

@dougsland
Copy link
Collaborator

@pengshanyu can you please review?

+1

@pengshanyu
Copy link
Collaborator

LGTM.

@dougsland dougsland merged commit 1b6a02a into containers:main Nov 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarboa Yarboa Yarboa approved these changes

@dougsland dougsland dougsland approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@nsednev nsednev Awaiting requested review from nsednev nsednev is a code owner

@pengshanyu pengshanyu Awaiting requested review from pengshanyu pengshanyu is a code owner

@kleinffm kleinffm Awaiting requested review from kleinffm kleinffm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aesteve-rh @Yarboa @dougsland @pengshanyu