Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding supported quadlet vars mappings #667

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Nov 26, 2024

Fix #668

Remove PodmanArgs, since the following mappings supported: rpm -q podman
podman-5.2.3-6.el9.x86_64

Unmask=ALL
SecurityLabelNested=true
SeccompProfile=/usr/share/qm/seccomp.json
PidsLimit=-1

Adding Readme related to updating qm quadlet file
It seems that currently there is usage in
/etc/qm/containers/containers.conf
Instead of extension of existing quadlet

Remove PodmanArgs, since the following mappings supported:
rpm -q podman
podman-5.2.3-6.el9.x86_64

Unmask=ALL
SecurityLabelNested=true
SeccompProfile=/usr/share/qm/seccomp.json
PidsLimit=-1

Adding Readme related to updating qm quadlet file
It seems that currently there is usage in
/etc/qm/containers/containers.conf
Instead of extension of existing quadlet

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa
Copy link
Collaborator Author

Yarboa commented Nov 26, 2024

testing-farm:fedora-41-x86_64:q

This is know issue #666

Copy link
Collaborator

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dougsland
Copy link
Collaborator

@pengshanyu

@pengshanyu
Copy link
Collaborator

LGTM

@dougsland dougsland merged commit da70aa5 into containers:main Nov 27, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and document QM quadlet files
3 participants