Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh #493

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update install.sh #493

merged 1 commit into from
Nov 26, 2024

Conversation

jtligon
Copy link
Contributor

@jtligon jtligon commented Nov 26, 2024

added a check for pipx in the install script

fixes #486

Summary by Sourcery

Enhancements:

  • Add a check for pipx in the install script to ensure it is installed before proceeding.

Copy link
Contributor

sourcery-ai bot commented Nov 26, 2024

Reviewer's Guide by Sourcery

The PR adds a dependency check for pipx in the installation script for macOS systems. If pipx is not available, the script will exit with an error message instructing the user to install it via Homebrew.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a dependency check for pipx in the macOS installation flow
  • Added a check to verify if pipx is available in the system
  • Added an error message prompting users to install pipx using brew if not found
  • Implemented a new return code (3) for the pipx missing scenario
install.sh

Assessment against linked issues

Issue Objective Addressed Explanation
#486 Add dependency check for pipx in the install script for macOS

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jtligon - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding the pipx dependency check for Linux systems as well to maintain consistency across platforms, unless there's a specific reason it's only needed for macOS.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2024

Thanks @jtligon
You need to sign your commits.

git commit -a --amend -s
git push --force

added a check for pipx in the install script

Signed-off-by: Jeff Ligon <[email protected]>
@jtligon
Copy link
Contributor Author

jtligon commented Nov 26, 2024

I should do this more often so that i remember to set up signing...

@rhatdan rhatdan merged commit 93c5291 into containers:main Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install script fails on macos - should check dependencies (pipx)
2 participants