-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install.sh #493
Update install.sh #493
Conversation
Reviewer's Guide by SourceryThe PR adds a dependency check for No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jtligon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding the pipx dependency check for Linux systems as well to maintain consistency across platforms, unless there's a specific reason it's only needed for macOS.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thanks @jtligon git commit -a --amend -s |
added a check for pipx in the install script Signed-off-by: Jeff Ligon <[email protected]>
f79a010
to
716da49
Compare
I should do this more often so that i remember to set up signing... |
added a check for pipx in the install script
fixes #486
Summary by Sourcery
Enhancements: