Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take in fixes from @churchyard to modernize spec file #494

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

smooge
Copy link
Collaborator

@smooge smooge commented Nov 26, 2024

Pull request was downstream at
https://src.fedoraproject.org/rpms/python-ramalama/pull-request/2 and this will make it match with upstream. At that point we will be able to automate with packit.

Summary by Sourcery

Enhancements:

  • Modernize the spec file by aligning it with upstream changes, including formatting adjustments and updates to build requirements.

Pull request was downstream at
https://src.fedoraproject.org/rpms/python-ramalama/pull-request/2 and
this will make it match with upstream. At that point we will be able
to automate with packit.

Signed-off-by: Stephen Smoogen <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Nov 26, 2024

Reviewer's Guide by Sourcery

This PR modernizes the spec file by adopting current RPM packaging best practices. The changes include updating package metadata formatting, simplifying conditional requirements, improving file handling through pyproject macros, and adding necessary package dependencies.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved package metadata and formatting
  • Renamed 'desc' global variable to 'summary' for better clarity
  • Aligned package metadata fields for better readability
  • Removed unnecessary debug_package directive
rpm/python-ramalama.spec
Updated build and runtime dependencies
  • Replaced golang-github-cpuguy83-md2man with go-md2man
  • Added unconditional requirement for python-tqdm instead of conditional
  • Added new dependency on python-omlmd package
  • Removed conditional checks for Fedora 40
rpm/python-ramalama.spec
Modernized Python packaging macros usage
  • Added pyproject_buildrequires section
  • Updated pyproject_save_files usage with -l flag
  • Added pyproject_check_import for package verification
  • Simplified files section using pyproject_files macro
rpm/python-ramalama.spec
Enhanced source preparation and documentation
  • Replaced forgesetup with forgeautosetup using -p1 flag
  • Duplicated package description in Python subpackage for completeness
  • Improved file section organization and clarity
rpm/python-ramalama.spec

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smooge - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2024

Builds are failing on centos-stream because of missing requiements tdqm?

Stephen Smoogen added 2 commits November 26, 2024 20:51
Currently there is no python-tqdm in CentOS Stream 10 so it needs to
be not used.

Signed-off-by: Stephen Smoogen <[email protected]>
The Fedora spec files need to use %python items which pull in build
requires. This breaks in CS10 because those packages don't exist and
so PR's cant work

Signed-off-by: Stephen Smoogen <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2024

LGTM

@rhatdan rhatdan merged commit bbf73a4 into containers:main Nov 26, 2024
11 checks passed
@smooge smooge deleted the fix_spec-v0.2.0 branch November 27, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants