-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take in fixes from @churchyard to modernize spec file #494
Conversation
Pull request was downstream at https://src.fedoraproject.org/rpms/python-ramalama/pull-request/2 and this will make it match with upstream. At that point we will be able to automate with packit. Signed-off-by: Stephen Smoogen <[email protected]>
Reviewer's Guide by SourceryThis PR modernizes the spec file by adopting current RPM packaging best practices. The changes include updating package metadata formatting, simplifying conditional requirements, improving file handling through pyproject macros, and adding necessary package dependencies. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @smooge - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Builds are failing on centos-stream because of missing requiements tdqm? |
Currently there is no python-tqdm in CentOS Stream 10 so it needs to be not used. Signed-off-by: Stephen Smoogen <[email protected]>
The Fedora spec files need to use %python items which pull in build requires. This breaks in CS10 because those packages don't exist and so PR's cant work Signed-off-by: Stephen Smoogen <[email protected]>
LGTM |
Pull request was downstream at
https://src.fedoraproject.org/rpms/python-ramalama/pull-request/2 and this will make it match with upstream. At that point we will be able to automate with packit.
Summary by Sourcery
Enhancements: