overlay: fallback without data only layers #2112
Conversation
if the overlay data only layers feature is not available, then use a regular overlay lower layer. The same functionality is already present in the mount helper for composefs. Signed-off-by: Giuseppe Scrivano <[email protected]>
| @@ -271,6 +272,18 @@ func (d *Driver) getSupportsVolatile() (bool, error) { | |||
| return supportsVolatile, nil | |||
| } | |||
|
|
|||
| func (d *Driver) getSupportsDataOnly() (bool, error) { | |||
There was a problem hiding this comment.
nit: getSupportsDataOnly->supportsDataOnly
There was a problem hiding this comment.
we already have a supportsDataOnly *bool in the Driver struct
|
@giuseppe, would it be possible to expose this as a warning or a small helper so that users such as CRI-O could want the user that composefs is working in a degraded or unsupported (or not fully supported?) mode? We will users that might not have the kernel feature ready or backported for a while... Unless you think handling this transparently is good enough. |
|
Is there any reason we need to reimplement the mount logic here versus just calling out to |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
we are using a single overlay mount on top of multiple erofs mounts and basedirs, so there is not a single |
|
Ah right, so this relates to #2018 |
|
For posterity: This fixes an issue CRI-O had on platforms where the kernel lacked the required support. |
if the overlay data only layers feature is not available, then use a regular overlay lower layer.
The same functionality is already present in the mount helper for composefs.