Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and cleanups for balancebot sim #137

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

gbin
Copy link
Collaborator

@gbin gbin commented Dec 5, 2024

No description provided.

@gbin
Copy link
Collaborator Author

gbin commented Dec 5, 2024

@Nashenas88 actually it was needed :)... because we have a race condition spawning the entities vs the resources loading. I added a boolean flag to not recreate the entities once they are build.

Do you mind checking if that restores the fps on your side too? Thanks

@gbin
Copy link
Collaborator Author

gbin commented Dec 5, 2024

@Nashenas88 actually it was needed :)...

I consistently get 60fps+ on my small integrated graphics laptop. 👍
Also with the perf-ui feature flag I added, you can see that the entities count stay the same ;)

@gbin gbin merged commit c5a3440 into master Dec 5, 2024
3 checks passed
@gbin gbin deleted the gbin/balancebot-cleanup branch December 5, 2024 21:56
@Nashenas88
Copy link
Contributor

Nashenas88 commented Dec 6, 2024

The updated version works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants