Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

platforms: add initial hetzner cloud support #164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dedene
Copy link

@dedene dedene commented Nov 27, 2018

@dedene
Copy link
Author

dedene commented Nov 27, 2018

@LKaemmerling Would you mind taking a look at this from the Hetzner Cloud team? Feel free to suggest changes.

@@ -23,6 +23,7 @@ This is the information available in each provider.
| Packet | ✓ | ✓ | ✓ | | ✓ |
| OpenStack-Metadata | ✓ | ✓ | ✓ | | |
| Vagrant-Virtualbox | ✓ | ✓ | | | |
| Hetzner Cloud | ✓ | ✓ | ✓ | | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hetzner Cloud does not have Private IPs (or VPN)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but the metadata service seem to have an endpoint for it (although returning an empty string). So my thought was to already add it for when or if Hetzner Cloud would add private networking in some hypothetical point in the future. Would you rather prefer to remove this?

@ajeddeloh
Copy link
Contributor

LGTM except maybe rename hcloud to hetznercloud.

@dedene
Copy link
Author

dedene commented Nov 28, 2018

@ajeddeloh Thanks for the feedback. See coreos/ignition#667 (comment) about my reasoning behind hcloud. Would you like me to change it to hetznercloud or can it remain hcloud?

@ajeddeloh
Copy link
Contributor

As per the Ignition PR discussion, hcloud is fine. I'll hold off on merging this until the Ignition PR is merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants