-
Notifications
You must be signed in to change notification settings - Fork 79
platforms: add initial hetzner cloud support #164
base: master
Are you sure you want to change the base?
Conversation
@LKaemmerling Would you mind taking a look at this from the Hetzner Cloud team? Feel free to suggest changes. |
@@ -23,6 +23,7 @@ This is the information available in each provider. | |||
| Packet | ✓ | ✓ | ✓ | | ✓ | | |||
| OpenStack-Metadata | ✓ | ✓ | ✓ | | | | |||
| Vagrant-Virtualbox | ✓ | ✓ | | | | | |||
| Hetzner Cloud | ✓ | ✓ | ✓ | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hetzner Cloud does not have Private IPs (or VPN)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No but the metadata service seem to have an endpoint for it (although returning an empty string). So my thought was to already add it for when or if Hetzner Cloud would add private networking in some hypothetical point in the future. Would you rather prefer to remove this?
LGTM except maybe rename hcloud to hetznercloud. |
@ajeddeloh Thanks for the feedback. See coreos/ignition#667 (comment) about my reasoning behind |
As per the Ignition PR discussion, |
Along with:
This will greatly enhance working with CoreOS on the Hetzner Cloud.