Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/kola/docker: Add a basic docker run test #2622

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

travier
Copy link
Member

@travier travier commented Sep 20, 2023

@travier
Copy link
Member Author

travier commented Sep 20, 2023

This will fail on next.

tests/kola/docker/basic Outdated Show resolved Hide resolved
dustymabe
dustymabe previously approved these changes Sep 20, 2023
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment, otherwise LGTM.

Also, for some reason CI is failing even on testing-devel.

@travier travier force-pushed the tests-docker-run branch 3 times, most recently from b03d67f to 8b409df Compare September 21, 2023 12:48
@travier
Copy link
Member Author

travier commented Sep 21, 2023

Updated.

dustymabe
dustymabe previously approved these changes Sep 21, 2023
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe enabled auto-merge (rebase) September 21, 2023 13:27
@travier
Copy link
Member Author

travier commented Sep 21, 2023

Fix interactive/tty not working in a systemd unit

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

[2023-09-21T15:15:38.461Z] --- PASS: ext.config.docker.basic (40.21s)

Merging so we can get this in to next-devel and next sooner.

@dustymabe dustymabe disabled auto-merge September 21, 2023 15:53
@dustymabe dustymabe merged commit aa43732 into coreos:testing-devel Sep 21, 2023
2 checks passed
@travier travier deleted the tests-docker-run branch September 22, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants