overlay/dracut: omit ifcfg module #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a while since we've moved to only propagating NM keyfiles from the initrd to the real root, so we no longer need this module. It currently still gets pulled in due to the `/etc/sysconfig/network- scripts` directory existing in the real root (which contains a README by default). There's a patch upstream to make it purely opt-in[[1]], but for now let's just explicitly opt out ourselves. (Note this has no impact on whether ifcfg in the real root is supported, which it still is in RHCOS. It just stops uselessly generating ifcfg files in the initrd.) [1]: dracutdevs/dracut#2529
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Sep 29, 2023
It's included by default currently so we don't need this. A patch in FCOS will actually make it so that we don't pull it in at all: coreos/fedora-coreos-config#2642 Part of the move away `initramfs-args`, which is deprecated: coreos/rpm-ostree#3834
cgwalters
approved these changes
Sep 29, 2023
HuijingHei
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since we've moved to only propagating NM keyfiles from the initrd to the real root, so we no longer need this module.
It currently still gets pulled in due to the
/etc/sysconfig/network- scriptsdirectory existing in the real root (which contains a README by default).There's a patch upstream to make it purely opt-in[1], but for now let's just explicitly opt out ourselves.
(Note this has no impact on whether ifcfg in the real root is supported, which it still is in RHCOS. It just stops uselessly generating ifcfg files in the initrd.)