Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootupd-validate: remove condition as we have newer bootupd #3300

Open
wants to merge 1 commit into
base: testing-devel
Choose a base branch
from

Conversation

HuijingHei
Copy link
Member

@HuijingHei
Copy link
Member Author

HuijingHei commented Dec 11, 2024

Hold on, as not yet tested it on ppc64le, will do testing if I could setup the env.

@HuijingHei
Copy link
Member Author

Test on ppc64le using rhcos-419.96.202412161243-0, result is PASS.

[coreos-assembler]$ kola run -E ./test --qemu-image rhcos-419.96.202412161243-0-qemu.ppc64le.qcow2 ext.test.boot.bootupd-validate
=== RUN   ext.test.boot.bootupd-validate
--- PASS: ext.test.boot.bootupd-validate (57.24s)
PASS, output in tmp/kola/qemu-2024-12-17-1255-489

Test on ppc64le using rhcos-419.94.202412142136, result is PASS.

[coreos-assembler]$ kola run -E ./test --qemu-image rhcos-419.94.202412142136-0-qemu.ppc64le.qcow2 ext.test.boot.bootupd-validate
=== RUN   ext.test.boot.bootupd-validate
--- PASS: ext.test.boot.bootupd-validate (43.38s)
PASS, output in tmp/kola/qemu-2024-12-17-1300-559

cosa build c9s, and run test, result is PASS.

$ kola run -E ./test ext.test.boot.bootupd-validate
=== RUN   ext.test.boot.bootupd-validate                                                                                                                                     
--- PASS: ext.test.boot.bootupd-validate (60.72s) 

@HuijingHei HuijingHei removed the hold label Dec 17, 2024
@dustymabe
Copy link
Member

considering openshift/os#1687 (comment) do we still need this?

@HuijingHei HuijingHei changed the title bootupd-validate: skip adopt test on ppc64le with older bootupd bootupd-validate: remove condition as we have newer bootupd Dec 18, 2024
@HuijingHei
Copy link
Member Author

considering openshift/os#1687 (comment) do we still need this?

Thanks for the pointer, refresh the code to remove the condition as we have the newer bootupd (https://issues.redhat.com/browse/RHEL-71040), could you help to review, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rhel-9.6/c9s: ext.config.shared.boot.bootupd-validate failing on ppc64le
2 participants