Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] tree: promote changes from testing-devel at 262ea8b2b031a81a3cb379a93803ebdc2d407709 #3304

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Dec 16, 2024

c4rt0
c4rt0 previously approved these changes Dec 16, 2024
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@c4rt0 c4rt0 enabled auto-merge (rebase) December 16, 2024 11:39
dustymabe
dustymabe previously approved these changes Dec 16, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marmijo
marmijo previously approved these changes Dec 16, 2024
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marmijo
Copy link
Member

marmijo commented Dec 16, 2024

Looks like CI is failing because of the bootc submodule. This happened during the last releases as well: #3279 (comment)

It's causing a CI failure and isn't used for <F42 for now.
@dustymabe dustymabe dismissed stale reviews from marmijo, c4rt0, and themself via 7783b46 December 16, 2024 21:10
@dustymabe
Copy link
Member

I just hit the easy button for now and pushed a commit to drop the submodule again.

@dustymabe dustymabe disabled auto-merge December 16, 2024 21:11
@dustymabe
Copy link
Member

CI still isn't working. I'm merging this and will deal with any consequences later.

@dustymabe dustymabe merged commit 3e4d901 into coreos:testing Dec 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants