This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Additional Robustness #792
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. added "-c" option to cache files (in case no access to internet or retry) 3. elaborated check for missing utilities (for operating systems such as mac an windows that don't include wget :-( 4. added option to refresh key (but won't die if refresh fails; useful for fully disconnected install with old cached files) 5. changed hash validation to openssl instead of sha1sum and sha512sum since some OS such as mac and windows are missing these utils :-( 6. added some extra error handling to dump out on error (specifically to prevent deleting the working dir)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are focused on restarting without having to re-download files in the event of an error. In some cases, the error may be because the script is running on a host without standard utils such as sha512hash (which under the original script was only detected after downloading the complete image). In other cases, it may be due to an unstable network connection. The existing script requires both virtualbox and a good network connection, so allowing a cache directory allows downloading on a machine with a good network connection and then manually copying to the virtualbox machine.
The intention of these changes is still to maintain 100% of the original crypto-validation (which is why it should be safe to used cached files no matter their origin).
retry)
as mac an windows that don't include wget :-(
for fully disconnected install with old cached files)
since some OS such as mac and windows are missing these utils :-(
prevent deleting the working dir)