This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
create-basic-configdrive: update etcd v2 to etcd v3 #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcd v2 has been deprecated and is replaced with etcd v3 (etcd-member)
|
Thanks for the PR! This script is pretty stale. We should drop the fleet service while we're here. Ideally the cloud-config would also be converted to Ignition, but I don't think that's strictly necessary. |
|
Good point, I didn't notice the fleet error until after I sent the PR PR has been updated with the fleet removal but I did not look into the Ignition part |
dm0-
reviewed
May 7, 2018
| @@ -26,17 +26,15 @@ This tool creates a basic config-drive ISO image. | |||
| CLOUD_CONFIG="#cloud-config | |||
|
|
|||
| coreos: | |||
| etcd2: | |||
| etcd-member: | |||
There was a problem hiding this comment.
Does this change work? It is not listed: https://github.com/coreos/coreos-cloudinit/blob/master/config/config.go#L39
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcd v2 has been deprecated and is replaced with etcd v3 (etcd-member)