Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to test updating programs #354

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

mattmccutchen-cci
Copy link
Member

This is to facilitate my work on factoring the RUN commands out of the test files for #346.

Copy link
Member

@mwhicks1 mwhicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but having the assumed path to the built binaries specified in the executable itself seems non-ideal. Why not assume its presence in PATH?

@mwhicks1 mwhicks1 removed the request for review from sroy4899 December 11, 2020 13:25
@mattmccutchen-cci mattmccutchen-cci force-pushed the test-updating-programs-minor branch from d8120ee to dd7df6c Compare December 11, 2020 16:40
@mattmccutchen-cci mattmccutchen-cci marked this pull request as draft December 11, 2020 16:57
- Make directly executable (on Linux at least).

- Chdir to the containing directory if needed.

- Search for `3c` via $LLVM_OBJ, the standard build directory location,
  and $PATH (in that order) rather than requiring the user to modify an
  absolute path hard-coded in the program.
@mattmccutchen-cci mattmccutchen-cci force-pushed the test-updating-programs-minor branch from dd7df6c to 2e1bde3 Compare December 11, 2020 17:25
@mattmccutchen-cci mattmccutchen-cci marked this pull request as ready for review December 11, 2020 17:25
@mattmccutchen-cci mattmccutchen-cci merged commit 9f36276 into master-post-microsoft Dec 11, 2020
@mattmccutchen-cci mattmccutchen-cci deleted the test-updating-programs-minor branch December 11, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants