Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some System.exit usages #78

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Remove some System.exit usages #78

merged 1 commit into from
Dec 6, 2024

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Dec 5, 2024 •
edited
Loading

With the removal of the security manager from JDK24, it is no longer feasible for the unit tests to intercept System.exit calls. Better to just remove these calls and throw IllegalArgumentException instead.

#77

@earthling-amzn earthling-amzn merged commit 4c7e556 into master Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdnilsen kdnilsen kdnilsen approved these changes

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@earthling-amzn @phohensee @kdnilsen