Upload corporate logo #1314

arymoraes · 2024-10-31T02:47:04Z

No description provided.

coderabbitai · 2024-10-31T02:47:10Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cpvalente · 2024-11-09T20:10:08Z

apps/client/src/common/api/project.ts

+/**
+ * HTTP request to upload a project logo
+ */
+export async function uploadProjectLogo(file: File): Promise<AxiosResponse<ProjectLogoResponse>> {


suggestion: I am not sure if we should have so many endpoints specific to the project logo

how about creating creating a patch project data endpoint?
We could add the logo here, if no logo is given, we delete existing logos.

What do you think?

Kept the upload endpoint, but removed the delete endpoint.

When we upload the image, it saves to the logos folder, then returns the path to it. We can see the preview, and if we Save, the projectLogo gets updated to the logo path.

apps/client/src/features/app-settings/panel/project-panel/ProjectData.tsx

cpvalente · 2024-11-09T20:12:17Z

apps/client/src/features/app-settings/panel/project-panel/ProjectData.tsx

@@ -86,6 +120,31 @@ export default function ProjectData() {
              {...register('title')}
            />
          </label>
+          <label>


can we use an upload card similar to what we have in the sheets page?

apps/server/src/services/project-service/projectServiceUtils.ts

cpvalente · 2024-11-09T20:16:52Z

packages/types/src/definitions/core/ProjectData.type.ts

@@ -5,4 +5,5 @@ export type ProjectData = {
  publicInfo: string;
  backstageUrl: string;
  backstageInfo: string;
+  projectLogo?: string;


question: we seem to have some varying approaches here. We define projectLogo as string | undefined, but use empty string to signify no logo

Would it be better to have this field be an union string | null so that the value is more explicit?

I changed it to string | null, but would this break existing projects that do not have that property on the json?

thank you for bringing this up. added a test to cover this case

cpvalente · 2024-11-17T21:41:58Z

@coderabbitai full review

coderabbitai · 2024-11-17T21:42:02Z

✅ Actions performed

Full review triggered.

arymoraes marked this pull request as ready for review November 3, 2024 04:06

cpvalente reviewed Nov 9, 2024

View reviewed changes

arymoraes and others added 19 commits November 17, 2024 22:44

feat: Base64 approach

104845c

feat: upload file endpoint

d01fed3

feat: image upload + form working

d4cdeea

feat: cleanup and name change

ff0fef3

feat: almost working, still not able to load logo on timer view

6ea66d5

feat: some cleanup on the code

73c09de

feat: fixed path to project and port constant

b41c46a

feat: fixed import hack for project logo

59757e8

feat: cleanup for project logos path

b3c1f2c

tweaks

909b10c

feat: functionality to remove logo

849aa7e

feat: removed delete endpoint, deleting logo on save

fb25960

feat: string | null type for project logo

238dda6

feat: better UI for logo upload

98b0183

feat: ref changes

516176c

feat: test fix

5fb4d9e

feat: test fix

15f2924

small tweaks

fceb726

chore: add migration test

31c59d6

cpvalente force-pushed the feat/upload_corporate_logo branch from 0364c6f to 31c59d6 Compare November 17, 2024 21:44

refactor: code review

91e5fe9

cpvalente merged commit a6e1cbb into master Nov 17, 2024
4 checks passed

cpvalente deleted the feat/upload_corporate_logo branch November 17, 2024 21:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload corporate logo #1314

Upload corporate logo #1314

arymoraes commented Oct 31, 2024

coderabbitai bot commented Oct 31, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cpvalente Nov 9, 2024

arymoraes Nov 17, 2024

cpvalente Nov 9, 2024

arymoraes Nov 17, 2024

cpvalente Nov 9, 2024

arymoraes Nov 17, 2024

cpvalente Nov 17, 2024

cpvalente commented Nov 17, 2024

coderabbitai bot commented Nov 17, 2024

Upload corporate logo #1314

Upload corporate logo #1314

Conversation

arymoraes commented Oct 31, 2024

coderabbitai bot commented Oct 31, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cpvalente Nov 9, 2024

Choose a reason for hiding this comment

arymoraes Nov 17, 2024

Choose a reason for hiding this comment

cpvalente Nov 9, 2024

Choose a reason for hiding this comment

arymoraes Nov 17, 2024

Choose a reason for hiding this comment

cpvalente Nov 9, 2024

Choose a reason for hiding this comment

arymoraes Nov 17, 2024

Choose a reason for hiding this comment

cpvalente Nov 17, 2024

Choose a reason for hiding this comment

cpvalente commented Nov 17, 2024

coderabbitai bot commented Nov 17, 2024

coderabbitai bot commented Oct 31, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)