fix: rolling over midnight wrongly classified as skip #1354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems that we were passing to the calculation, the time the last integration was fired, rather than the last update
this meant that the skip threshold (1000ms) was potentially higher than the update rate (>1000ms) and could cause issues
This is mostly a patch and maybe not the best fix. However, I couldnt think of a fix here other than guaranteeing that the
skipLimit
must be higher than the clockupdateRate
Also made a quick change to the time added tooltip to avoid showing like "added 946 seconds"