-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Didn't work out of the box on my system: header fields should be case-insensitive. #1
Open
berenddeboer
wants to merge
3
commits into
crocos:master
Choose a base branch
from
berenddeboer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ If you want usage detail, type `--help`. | |
``` | ||
|
||
When standalone, build php version is system default. | ||
If you want use other php version, you can change `phpize` and `php-config` command by parameter. | ||
If you want to use another php version, you can change `phpize` and `php-config` command by parameter. | ||
|
||
``` | ||
$ bin/pecl-build <package_naem> -p /path/to/phpize -i /path/to/php-config | ||
|
@@ -22,12 +22,12 @@ $ bin/pecl-build <package_naem> -p /path/to/phpize -i /path/to/php-config | |
### Use phpenv plugins | ||
|
||
``` | ||
% git clone https://github.com/crocos/pecl-build.git $PHPENV_ROOT/plugins/pecl-build | ||
% git clone https://github.com/berenddeboer/pecl-build.git $PHPENV_ROOT/plugins/pecl-build | ||
% phpenv pecl <package_name> | ||
``` | ||
|
||
phpenv plugin follow php version for phpenv specified. | ||
If you want specify build php version, you can set parameter. | ||
phpenv plugin follows the php version installed by phpenv. | ||
If you want to build for a specific php version, you can specify a parameter. | ||
|
||
``` | ||
% phpenv pecl <package_name> -j <php version> | ||
|
@@ -53,4 +53,3 @@ so created `.ini` config set `zend_extension` | |
* Initial Version | ||
|
||
AUTHOR:: Daichi Kamemoto <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ usage() { | |
echo " --dry dry run mode." | ||
echo " -d, --base-dir specified build directory. (default: /tmp/pecl-build)" | ||
echo " -p, --phpize absolute path for phpize. (default: environment dependent)" | ||
echo " -i, --php-config aboslute path for php-config. (default: environment dependent)" | ||
echo " -i, --php-config absolute path for php-config. (default: environment dependent)" | ||
echo " -c, --configure-options additional configure options. (default: nothing)" | ||
echo " -z, --zend-extension registerd zend_extensin at ini file generated." | ||
echo " --skip-test skip make test." | ||
|
@@ -57,13 +57,13 @@ main() { | |
debug "install package: $(green $package)" | ||
|
||
# extension build base dir | ||
if [ "x$base_dir" = "x" ];then | ||
if [ -z $base_dir ];then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What did you change to solve? |
||
base_dir=/tmp/pecl-build | ||
fi | ||
debug "base_dir: $(green $base_dir)" | ||
|
||
# phpize command path | ||
if [ "x$phpize" = "x" ];then | ||
if [ -z $phpize ];then | ||
phpize=phpize | ||
else | ||
phpize=$(echo $phpize) # path expantion | ||
|
@@ -75,12 +75,12 @@ main() { | |
debug "phpize command: $(green $phpize)" | ||
|
||
# additional configure options | ||
if [ "x$configure_options" = "x" ];then | ||
if [ -z $configure_options ];then | ||
configure_options= | ||
fi | ||
|
||
# php-config command path | ||
if [ "x$phpconfig" = "x" ];then | ||
if [ -z $phpconfig ];then | ||
phpconfig=php-config | ||
else | ||
phpconfig=$(echo $phpconfig) #path expantion | ||
|
@@ -96,11 +96,11 @@ main() { | |
|
||
### main ### | ||
|
||
# crete build base | ||
# create build base | ||
pecl_url=http://pecl.php.net/get | ||
url=$pecl_url/$package | ||
|
||
tarball=$(curl -I $url 2>/dev/null |grep Content-disposition |cut -d'=' -f2 |tr -d \") | ||
tarball=$(curl -I $url 2>/dev/null |grep -i Content-disposition |cut -d'=' -f2 |tr -d \") | ||
package_name=${tarball%.*} | ||
extension=${package_name%-*} | ||
version=${package_name##*-} | ||
|
@@ -113,10 +113,10 @@ main() { | |
debug "version: $(green $version)" | ||
debug "build_dir: $(green $build_dir)" | ||
|
||
info "create build directory: $(green $build_dir)" | ||
info "creating build directory: $(green $build_dir)" | ||
run mkdir -p $build_dir | ||
if [ -e "$build_dir/$package_name" ];then | ||
warn "already exist old dir. remove it." | ||
warn "removing exist old dir $build_dir/$package_name." | ||
run rm -rf $build_dir/$package_name | ||
fi | ||
|
||
|
@@ -208,4 +208,3 @@ debug() { | |
|
||
# call main. | ||
main "$@" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please point origin repository here 😃