Create a ScalaXB Plugin #556
Conversation
|
|
|
@Jacoby6000 in order to sign the CLA you need to add the email address used in your commits to your github account. |
| case object OkHttp extends Backend | ||
| case object AHC extends Backend | ||
| } | ||
| } |
There was a problem hiding this comment.
can we take the Gigahorse stuff out of the cbt package?
There was a problem hiding this comment.
I can, but it's built in to scalaxb, so the binaries will still be floating around in there.. scalaxb has a tight coupling to it's backends from what I understand.
There was a problem hiding this comment.
I mean, can we move inside of a scalaxb plugin specific object or package? Just so it doesn't lie around in cbt's global namespace
|
will look into the crash now :) |
|
Getting closer. This seems be be caused by cbt itself using an older Scala version (2.11.8) than one of the dependencies of the plugin (2.11.11). We could temporarily fix this problem but upgrading cbt's scala version but it would also apply again whenever a new Scala version comes out. Will have to think of a solution for this. Nice find in any case. This would have popped up soon anyways. |
|
btw. the way I found out is by printing the classloader in the top line of cbt in the StackTrace of the crash. |
|
While I am still working on a more permanent fix, if you rebase your PR on this one: #560 you should be unblocked. Upgrading scala to 2.11.11 solved the problem for now. Note that there is still a crash, but it looks like a problem in your plugin this time. |
|
(#560 currently fails the build, but don't worry about that. It looks like it only affect cross-cbt-version integration, which shouldn't block you here and I'll look into as well) |
|
Awesome, thanks for looking in to this! I'll poke at it in a bit. |
Jacoby6000
force-pushed
the
feature/scalaxb-plugin
branch
from
af5938e to
37d451a
Compare
|
I'll work on the tests, since we've addressed that classloader issue |
Most of this seems to work, aside from a class loader issue that's preventing me from testing it.
Any suggestions for improvements welcome while I try to sort it out!