WIP, redesigning forecast.py; #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using composition to break forecasters into elementary ones; will add logic to manage "workspace" in BaseForecast so each is evaled only once; need to untangle EMW-MW logic which was too complicated; hopefully will make more advanced forecasters easier to develop; will also merge cache.py into BaseForecast and remove related logic from simulator.py in this branch and merge for 1.4.0
moving docstrings, need minor fixes in tests, linear regression logic is still embryonic only
next can remove most old code from forecast module; finalized estimate method; need minor fixes tests
need only adapt regression forecaster and its test
only aggregation test on regression fails; need to rewrite that whole part anyways
…nto forecasts-improved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using composition to break forecasters into
elementary ones; will add logic to manage "workspace" in BaseForecast so each is evaled only once; need to untangle EMW-MW logic which was too complicated;
hopefully will make more advanced forecasters easier to develop; will also merge cache.py into BaseForecast and remove related logic from simulator.py in this branch and merge for 1.4.0