Change method naming

cybercog · Sep 3, 2024 · e2e3b27 · e2e3b27
1 parent 3bdc028
commit e2e3b27
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ This package does not cover Telnet API, and that's why:
 - HTTP API use cases: production applications, complex data queries, integrations with other systems, and secure communications.
 
 OpenTSDB HTTP API supported by:
-- [VictoriaMetrics](https://docs.victoriametrics.com/#sending-opentsdb-data-via-http-apiput-requests) but because of [limitation](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/959) `sendDataPointListSilently` should be used to send metrics.
+- [VictoriaMetrics](https://docs.victoriametrics.com/#sending-opentsdb-data-via-http-apiput-requests) but because of [limitation](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/959) `sendDataPointListWithDebug` method is not supported.
 
 ## What is OpenTSDB
 

diff --git a/src/OpenTsdbClient.php b/src/OpenTsdbClient.php
@@ -32,28 +32,6 @@ public function __construct(
      */
     public function sendDataPointList(
         array $dataPointList,
-    ): SendDataPointListResponse {
-        $result = $this->sendRequest(
-            $this->buildUrl('/api/put?details&summary'),
-            json_encode($dataPointList),
-        );
-
-        $statusCode = $result->getStatusCode();
-        $decodedResult = json_decode($result->getBody()->getContents(), true);
-
-        return new SendDataPointListResponse(
-            $statusCode,
-            $decodedResult['success'],
-            $decodedResult['failed'],
-            $decodedResult['errors'],
-        );
-    }
-
-    /**
-     * @param list<DataPoint> $dataPointList
-     */
-    public function sendDataPointListSilently(
-        array $dataPointList,
     ): void {
         $result = $this->sendRequest(
             $this->buildUrl('/api/put'),
@@ -128,6 +106,28 @@ public function sendDataPointListSilently(
         }
     }
 
+    /**
+     * @param list<DataPoint> $dataPointList
+     */
+    public function sendDataPointListWithDebug(
+        array $dataPointList,
+    ): SendDataPointListResponse {
+        $result = $this->sendRequest(
+            $this->buildUrl('/api/put?details&summary'),
+            json_encode($dataPointList),
+        );
+
+        $statusCode = $result->getStatusCode();
+        $decodedResult = json_decode($result->getBody()->getContents(), true);
+
+        return new SendDataPointListResponse(
+            $statusCode,
+            $decodedResult['success'],
+            $decodedResult['failed'],
+            $decodedResult['errors'],
+        );
+    }
+
     private function sendRequest(
         string $url,
         string $body,

diff --git a/test/Integration/OpenTsdbClientTest.php b/test/Integration/OpenTsdbClientTest.php
@@ -41,7 +41,7 @@ public function testSuccess(): void
 
         $openTsdbClient = $this->initOpenTsdbClient();
 
-        $response = $openTsdbClient->sendDataPointList($dataPointList);
+        $response = $openTsdbClient->sendDataPointListWithDebug($dataPointList);
         $this->assertSame(200, $response->httpStatusCode());
         $this->assertSame(2, $response->success());
         $this->assertSame(0, $response->failed());