Match literal underscore in LIKE pattern "pg\_%" #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that is a bug, and your fix is correct. Instead of creating a Also, I think that the regression tests could be shorter. I think that it is good enough to test a table, and we don't need to verify that the improved pattern also works for a schema containing a sequence as well. |
`_` matches single character in LIKE pattern matching, so a pattern `LIKE 'pg_%'` would match anything that starts with `pg` and is at least 3 characters long, like 'pg1'. To correct matching pattern and only match `pg_%` we need to escape literal underscore `pg\_%`
dodobas
force-pushed
the
fix-LIKE-pattern-matching
branch
from
7062cee to
7190951
Compare
|
Thank you for the input, I've updated the PR. I've used |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_matches single character in LIKE pattern matching, so a patternLIKE 'pg_%'would match anything that starts withpgand is at least3 characters long, like 'pg1'.
To correct matching pattern and only match
pg_%we need to escape literal underscorepg\_%