Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
UltimateAndroid
developers, I'm doing research on Android async programming, particularly onAsyncTask and IntentService. AsyncTask can lead to memory leak and losing task result when GUI is recreated during task running (such as orientation change). This article describes the problems very well.
We discussed with some Android experts and they agree with this issue, and claim that AsyncTask can be considered only for short tasks (less than 1 second). However, using IntentService (or AsyncTaskLoader) can avoid such problems since their lifecycles are independent from
Activity
/Fragment
.In
UltimateAndroid
, the AsyncTasks are declared as non-static inner classes ofActivity
/Fragment
. So the above issue can occur (especially for relatively long tasks).I refactored 6 AsyncTasks in
UltimateAndroid
to IntentService (in 6 separate commits), with the help of a refactoring tool we developed. Do you think using IntentService should be better in some of these 6 scenario? Do you want to merge some commits in this pr? Thanks.