1615 adding houghcircles #1616
Merged
1615 adding houghcircles #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add hough_circle helper function still need to add tests.
test added for hough_circle helper function
add auto_well roi method to roi methods based on new hough_circle helper function.
Closed
maliagehan
added
enhancement
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
trying to fix this?
docstringsssssssss space
dostringsssss
remove whitespace
Resolved issues in plantcv/plantcv/_helpers.py with DeepSource Autofix
maliagehan
added
ready to review
work in progress
|
going to add some debug images to help with parameterizing this function. Also going to add a check to see if the number of found circles is greater than the number of wells |
added a parameter so that this step is not slow if a lot of circles are found, will help user to parameterize function
added a fatal error if no circles are found
removed print statement
HaleySchuhl
added
ready to review
and removed
work in progress
k034b363
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Everything works just fine, the only small issue is that in the docs when searching for this function, both auto_wells and auto_grid come up with basically all the same search terms and it's a little hard to find auto_wells. The only thing that distinguishes the docs pages is that auto_wells includes that they are circular rois, which auto_grid's are as well. Might just be something to think about for ease of use down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a hough circle helper function, then one function that uses that helper (auto_wells) along with documentation and tests.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
#1615
Additional context
There are other functions that would be built off of the hough circle helper function, but they would require different data outputs.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md