Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto color correct wrapper #1625

Merged
merged 19 commits into from
Dec 13, 2024
Merged

Auto color correct wrapper #1625

merged 19 commits into from
Dec 13, 2024

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Nov 5, 2024 •
edited by k034b363
Loading

Describe your changes
Adds a wrapper that enables someone to do color corrections in one step.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added the update Updates an existing feature/method label Nov 5, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.6 milestone Nov 5, 2024
@HaleySchuhl HaleySchuhl self-assigned this Nov 5, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Nov 5, 2024 •
edited
Loading

Here's the code health analysis summary for commits 22afbd0..f033097. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

nfahlgren
nfahlgren requested changes Nov 8, 2024
View reviewed changes
docs/updating.md Outdated Show resolved Hide resolved
tests/plantcv/transform/test_auto_correct_color.py Show resolved Hide resolved
@k034b363 k034b363 self-requested a review November 11, 2024 20:50
k034b363
k034b363 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Test notebook with two additional images added to drive.

@nfahlgren nfahlgren merged commit 9e8e5bf into main Dec 13, 2024
5 checks passed
@nfahlgren nfahlgren deleted the auto_color_correct_wrapper branch December 13, 2024 23:24
@HaleySchuhl HaleySchuhl mentioned this pull request Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k034b363 k034b363 k034b363 approved these changes

@nfahlgren nfahlgren nfahlgren approved these changes

Assignees

@HaleySchuhl HaleySchuhl

Labels
ready to review update Updates an existing feature/method
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@HaleySchuhl @nfahlgren @k034b363